Update pg_hba generation #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,6 +19,8 @@ if [ "$1" = 'postgres' ]; then | |||
| cat >&2 <<-'EOWARN' | |||
| **************************************************** | |||
| WARNING: No password has been set for the database. | |||
| This will allow anyone to connect to your | |||
| postgres database. | |||
There was a problem hiding this comment.
I think this needs a tiny bit more information about exactly who can connect, because it's not really "anyone", it's "anyone with access to the port".
My take:
This will allow anyone with access to the Postgres port to access your database. In Docker's default configuration, this is effectively any other container on the same system.
Use "-e POSTGRES_PASSWORD=password" to set a password in "docker run".
|
Other than nitpicking the wording of the message, LGTM. |
|
Updated, ping @tianon. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that it no longer blocks on username. If no
POSTGRES_PASSWORDis specified it will be very insecure (trustany user from anywhere), otherwise it will havemd5as the auth method.Fixes: #47
Related: #31